> On Feb. 21, 2018, 1:32 p.m., Peter Vary wrote: > > Ship It!
Thanks a lot Peter for the review! - Marta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65730/#review197847 ----------------------------------------------------------- On Feb. 21, 2018, 10:36 a.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65730/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2018, 10:36 a.m.) > > > Review request for hive, Peter Vary and Adam Szita. > > > Bugs: HIVE-18697 > https://issues.apache.org/jira/browse/HIVE-18697 > > > Repository: hive-git > > > Description > ------- > > Extended the HiveMetastore.exchange_partitions method to check if the > partitionsToExchange list is empty and if it is throw a MetaException with a > proper error message that no partition exists with the given values for the > source table. Previously a FileNotFoundException was thrown (wrapped in a > MetaException) when tried to move the partition folder to the dest table. So > the type of the exception was not changed, only the error message. > > > Diffs > ----- > > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 47de215 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestExchangePartitions.java > 3a06aec > > > Diff: https://reviews.apache.org/r/65730/diff/1/ > > > Testing > ------- > > There are tests for this use case in TestExchangePartitions: > - testExchangePartitionsNoPartExists > - testExchangePartitionNoPartExists > > > Thanks, > > Marta Kuczora > >
