----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65947/ -----------------------------------------------------------
Review request for hive, Peter Vary and Adam Szita. Bugs: HIVE-18892 https://issues.apache.org/jira/browse/HIVE-18892 Repository: hive-git Description ------- The TestExchangePartitions tests revealed that NPE is thrown if the exchange_partitions method is called with null, empty or non-existing DB and table names. These NPEs could be prevented with a simple null check and a MetaException with a proper error message should be thrown instead. Diffs ----- standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 662de9a standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestExchangePartitions.java 5b21491 Diff: https://reviews.apache.org/r/65947/diff/1/ Testing ------- Run the TestExchangePartitions tests. Thanks, Marta Kuczora