----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65498/#review199113 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/Utils.java Line 55 (original), 56 (patched) <https://reviews.apache.org/r/65498/#comment279417> same as other comment - why change many places to a more general type just to add casts in other places? at least before the dependency on specific type was compile time verified, now it's run time verified service/src/java/org/apache/hive/service/server/HS2ActivePassiveHARegistry.java Lines 183 (patched) <https://reviews.apache.org/r/65498/#comment279418> until? should there be a followup jira? :) service/src/java/org/apache/hive/service/server/HS2ActivePassiveHARegistry.java Lines 198 (patched) <https://reviews.apache.org/r/65498/#comment279421> nit: maybe the latch listener can be hidden in a non-static nested class... otherwise the interface implementation is visible to the users and these methods are a bit confusing. service/src/java/org/apache/hive/service/server/HS2ActivePassiveHARegistry.java Lines 202 (patched) <https://reviews.apache.org/r/65498/#comment279419> just wondering, how is this protected from races? is there some grace period? should this be configurable/documented? I.e. is it possible to check hasLeadership() just before losing it, but still publish this? service/src/java/org/apache/hive/service/server/HS2ActivePassiveHARegistry.java Lines 268 (patched) <https://reviews.apache.org/r/65498/#comment279420> nit: javadoc - Sergey Shelukhin On March 13, 2018, 6:41 p.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65498/ > ----------------------------------------------------------- > > (Updated March 13, 2018, 6:41 p.m.) > > > Review request for hive, Sergey Shelukhin and Thejas Nair. > > > Bugs: HIVE-18281 > https://issues.apache.org/jira/browse/HIVE-18281 > > > Repository: hive-git > > > Description > ------- > > HIVE-18281: HiveServer2 HA for LLAP and Workload Manager > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java aedd1ec > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestActivePassiveHA.java > PRE-CREATION > > itests/util/src/main/java/org/apache/hive/jdbc/miniHS2/AbstractHiveService.java > 6cab8cd > itests/util/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java 8bbf8a4 > > llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceRegistry.java > 5d7f813 > > llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java > c88198f > > llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java > 80a6aba > > llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapZookeeperRegistryImpl.java > 8339230 > > llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenClient.java > 32d5caa > llap-client/src/java/org/apache/hadoop/hive/registry/RegistryUtilities.java > PRE-CREATION > llap-client/src/java/org/apache/hadoop/hive/registry/ServiceInstance.java > 908b3bb > > llap-client/src/java/org/apache/hadoop/hive/registry/ServiceInstanceSet.java > 34fba5c > > llap-client/src/java/org/apache/hadoop/hive/registry/impl/ServiceInstanceBase.java > db3d788 > > llap-client/src/java/org/apache/hadoop/hive/registry/impl/TezAmInstance.java > 0724cf5 > > llap-client/src/java/org/apache/hadoop/hive/registry/impl/TezAmRegistryImpl.java > 417e571 > > llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java > 17269dd > llap-common/src/java/org/apache/hadoop/hive/llap/metrics/MetricsUtils.java > 9666517 > > llap-ext-client/src/java/org/apache/hadoop/hive/llap/LlapBaseInputFormat.java > 0120639 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/services/impl/LlapWebServices.java > 58bf8dc > > llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java > 66de3b8 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java > 46cfe56 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java b98fb58 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/Utils.java bc438bb > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapClusterStateForCompile.java > a8d729d > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java > d261623 > > service/src/java/org/apache/hive/service/server/HS2ActivePassiveHARegistry.java > PRE-CREATION > > service/src/java/org/apache/hive/service/server/HS2ActivePassiveHARegistryClient.java > PRE-CREATION > service/src/java/org/apache/hive/service/server/HiveServer2.java b7ece2b > > service/src/java/org/apache/hive/service/server/HiveServer2HAInstanceSet.java > PRE-CREATION > service/src/java/org/apache/hive/service/server/HiveServer2Instance.java > PRE-CREATION > service/src/java/org/apache/hive/service/servlet/HS2LeadershipStatus.java > PRE-CREATION > service/src/java/org/apache/hive/service/servlet/HS2Peers.java PRE-CREATION > > > Diff: https://reviews.apache.org/r/65498/diff/3/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
