----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66068/#review199185 -----------------------------------------------------------
Fix it, then Ship it! LGTM serde/src/java/org/apache/hadoop/hive/serde2/avro/InstanceCache.java Line 29 (original), 29 (patched) <https://reviews.apache.org/r/66068/#comment279493> Didn't the author really mean memoizes https://en.wikipedia.org/wiki/Memoization - Vihang Karajgaonkar On March 14, 2018, 4:10 p.m., David Mollitor wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66068/ > ----------------------------------------------------------- > > (Updated March 14, 2018, 4:10 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > [HIVE-16882] Improvements For Avro SerDe Package > > > Diffs > ----- > > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java > b7b3d12 > > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroLazyObjectInspector.java > e1e4d8b > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java 1746a0f > serde/src/java/org/apache/hadoop/hive/serde2/avro/InstanceCache.java > 2d52020 > > > Diff: https://reviews.apache.org/r/66068/diff/1/ > > > Testing > ------- > > > Thanks, > > David Mollitor > >
