----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66098/#review199309 -----------------------------------------------------------
llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java Lines 595 (patched) <https://reviews.apache.org/r/66098/#comment279606> why do we have to set uniqId again? it should be set during registration right? llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java Lines 255 (patched) <https://reviews.apache.org/r/66098/#comment279607> nit: should this start with 0? llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java Lines 518 (patched) <https://reviews.apache.org/r/66098/#comment279608> nit: log the version? - Prasanth_J On March 15, 2018, 8:15 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66098/ > ----------------------------------------------------------- > > (Updated March 15, 2018, 8:15 p.m.) > > > Review request for hive and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > > llap-client/src/java/org/apache/hadoop/hive/registry/impl/TezAmInstance.java > 0724cf5b1f > > llap-client/src/java/org/apache/hadoop/hive/registry/impl/TezAmRegistryImpl.java > 417e571b8d > > llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java > 17269dddf7 > > llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java > 66de3b805a > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/GuaranteedTasksAllocator.java > 82b38d55b4 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/QueryAllocationManager.java > a44690283b > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java > 0962460b8f > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java d4c3ab9952 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java > 00e2c20eeb > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java > 8d185ba801 > > > Diff: https://reviews.apache.org/r/66098/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
