> On Март 19, 2018, 10:03 п.п., Vineet Garg wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > > Lines 12767 (patched) > > <https://reviews.apache.org/r/66131/diff/1/?file=1979896#file1979896line12769> > > > > Shouldn't this be under if(hivestatsautogather==false) ? Otherwise this > > will always end up clearing the stats properties.
I think it shouldn't be. It makes no sense.Because in DDLTask#createTableLike we will set up new stats properties for this table and stats from original table will be overrided. - Igor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66131/#review199480 ----------------------------------------------------------- On Март 19, 2018, 6:57 п.п., Igor Kryvenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66131/ > ----------------------------------------------------------- > > (Updated Март 19, 2018, 6:57 п.п.) > > > Review request for hive, Ashutosh Chauhan, Jesús Camacho Rodríguez, and > Prasanth_J. > > > Bugs: HIVE-18983 > https://issues.apache.org/jira/browse/HIVE-18983 > > > Repository: hive-git > > > Description > ------- > > Currently, Create table like support table properties. > But it doesn't inherit table properties from original table. > It uses just default table properties and doesn't inherit properties from > original table. > It would be great if create table like will inherit origin table properties > and will override them if they are specified in query . > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 2342fff2ebe7914dae4fe644c6a2182edf0ff08a > ql/src/test/results/clientpositive/create_alter_list_bucketing_table1.q.out > e74be6221d08b7b06d56e63db9e94d6df8e0c388 > ql/src/test/results/clientpositive/create_like.q.out > 7c26a597a59de8a4861518e4279cd995446e9991 > ql/src/test/results/clientpositive/create_like2.q.out > 601b929a2d557255cbf29aa9a5ca3752eda41920 > ql/src/test/results/clientpositive/explain_ddl.q.out > 6506e89035e1f1b2b4950175f888f463183cd34d > > standalone-metastore/src/main/java/org/apache/hadoop/hive/common/StatsSetupConst.java > 78ea01d9687fe043d63441430c46b30c25cd9756 > > > Diff: https://reviews.apache.org/r/66131/diff/1/ > > > Testing > ------- > > > Thanks, > > Igor Kryvenko > >
