----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66288/#review199994 -----------------------------------------------------------
The fix itself is fine, just some comments about comments. hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java Line 71 (original), 71 (patched) <https://reviews.apache.org/r/66288/#comment280515> Nit: The first Javadoc sentence should not include links. hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java Line 73 (original), 73 (patched) <https://reviews.apache.org/r/66288/#comment280516> Nit: Please use <p> for paragraph separation. hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java Line 75 (original), 75 (patched) <https://reviews.apache.org/r/66288/#comment280517> s/puts// hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java Line 76 (original), 76 (patched) <https://reviews.apache.org/r/66288/#comment280518> Can you add a description of how this event ID is generated. This is a very important piece of functionality. hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java Lines 82 (patched) <https://reviews.apache.org/r/66288/#comment280519> Nit: use <p> hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java Lines 87 (patched) <https://reviews.apache.org/r/66288/#comment280520> It is important to note that this is R/W lock and it is obtained using SELECT FOR UPDATE for the single row. hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java Lines 89 (patched) <https://reviews.apache.org/r/66288/#comment280521> s/is can/is likely to/ - Alexander Kolbasov On March 26, 2018, 7:42 p.m., Vihang Karajgaonkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66288/ > ----------------------------------------------------------- > > (Updated March 26, 2018, 7:42 p.m.) > > > Review request for hive and Alexander Kolbasov. > > > Bugs: HIVE-18885 > https://issues.apache.org/jira/browse/HIVE-18885 > > > Repository: hive-git > > > Description > ------- > > HIVE-18885 : DbNotificationListener has a deadlock between Java and DB locks > (2.x line) > > > Diffs > ----- > > > hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java > 41347c22df21a678241edeb766264e6d19c7885a > > > Diff: https://reviews.apache.org/r/66288/diff/1/ > > > Testing > ------- > > > Thanks, > > Vihang Karajgaonkar > >
