----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66236/#review200087 -----------------------------------------------------------
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/services/impl/LlapIoMemoryServlet.java Line 62 (original), 62 (patched) <https://reviews.apache.org/r/66236/#comment280732> nit: whitespace ql/src/java/org/apache/hadoop/hive/ql/processors/HiveCommand.java Lines 82 (patched) <https://reviews.apache.org/r/66236/#comment280734> nit: should there be a method for "llap" sub-commands? just to separate the ifs for llap ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveOperationType.java Lines 150 (patched) <https://reviews.apache.org/r/66236/#comment280735> does this also need to be added somewhere for ranger? right now for some Hive commands, ranger stuff works via query outputs, so e.g. in DDLSA: private void analyzeKillQuery(ASTNode ast) throws SemanticException { .. addServiceOutput(); .. rootTasks.add(TaskFactory.get(new DDLWork(getInputs(), getOutputs(), desc))); } private void addServiceOutput() throws SemanticException { String hs2Hostname = getHS2Host(); if (hs2Hostname != null) { outputs.add(new WriteEntity(hs2Hostname, Type.SERVICE_NAME)); } } - Sergey Shelukhin On March 27, 2018, 11:11 p.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66236/ > ----------------------------------------------------------- > > (Updated March 27, 2018, 11:11 p.m.) > > > Review request for hive, Gopal V and Sergey Shelukhin. > > > Bugs: HIVE-19033 > https://issues.apache.org/jira/browse/HIVE-19033 > > > Repository: hive-git > > > Description > ------- > > HIVE-19033: Provide an option to purge LLAP IO cache > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 5888eaa > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/authorization/TestJdbcWithSQLAuthorization.java > 9e021ea > llap-client/src/java/org/apache/hadoop/hive/llap/io/api/LlapIo.java 6e6f5b9 > > llap-common/src/gen/protobuf/gen-java/org/apache/hadoop/hive/llap/daemon/rpc/LlapDaemonProtocolProtos.java > 4753812 > > llap-common/src/java/org/apache/hadoop/hive/llap/impl/LlapManagementProtocolClientImpl.java > af760b1 > > llap-common/src/java/org/apache/hadoop/hive/llap/protocol/LlapManagementProtocolPB.java > ff215d4 > llap-common/src/protobuf/LlapDaemonProtocol.proto 12beca5 > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/CacheContentsTracker.java > 4fbaac1 > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCachePolicy.java > 2cd70b9 > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelFifoCachePolicy.java > 50a2411 > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java > b42f761 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapProtocolServerImpl.java > 81785f0 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java > e5bc3c2 > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelCacheImpl.java > 2c87bc2 > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestOrcMetadataCache.java > f7ebff2 > > ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorFactory.java > 74a34b3 > ql/src/java/org/apache/hadoop/hive/ql/processors/HiveCommand.java c45563d > > ql/src/java/org/apache/hadoop/hive/ql/processors/LlapCacheResourceProcessor.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/processors/LlapClusterResourceProcessor.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveOperationType.java > 5d6905a > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java > a55e66b > > service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java > e3a5922 > > > Diff: https://reviews.apache.org/r/66236/diff/3/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
