----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66356/#review200187 -----------------------------------------------------------
Ship it! Ship It! - Peter Vary On March 29, 2018, 9:54 a.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66356/ > ----------------------------------------------------------- > > (Updated March 29, 2018, 9:54 a.m.) > > > Review request for hive, Peter Vary and Adam Szita. > > > Bugs: HIVE-19075 > https://issues.apache.org/jira/browse/HIVE-19075 > > > Repository: hive-git > > > Description > ------- > > The TestDatabases tests revealed that NPE is thrown if the get_database_core > and drop_database_core methods are called with null DB name. These NPEs could > be prevented with a simple null check and a MetaException with a proper error > message should be thrown instead. > > Example: NPE is thrown in the following test cases > - TestDatabases.testGetDatabaseNullName > - TestDatabases.testDropDatabaseNullName > > > Diffs > ----- > > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 8a5de09 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java > f2d745e > > > Diff: https://reviews.apache.org/r/66356/diff/1/ > > > Testing > ------- > > > Thanks, > > Marta Kuczora > >
