> On April 4, 2018, 12:34 a.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > > Lines 408 (patched) > > <https://reviews.apache.org/r/65985/diff/2/?file=1976883#file1976883line409> > > > > why do we need !success check here?
Ah? Thanks, I missed this. I removed the first condition and leave this one instead. - Sergio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65985/#review200405 ----------------------------------------------------------- On March 15, 2018, 5:45 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65985/ > ----------------------------------------------------------- > > (Updated March 15, 2018, 5:45 p.m.) > > > Review request for hive, Alexander Kolbasov, Sahil Takiar, and Vihang > Karajgaonkar. > > > Bugs: HIVE-18783 > https://issues.apache.org/jira/browse/HIVE-18783 > > > Repository: hive-git > > > Description > ------- > > HIVE-16164 introduced a mechanism to pass HMS notification events ID to the > post-commit listeners for all DDL operations, but it didn't add it to the > ALTER TABLE event. This patch in review adds the same behavior for ALTER > TABLE events. > > > Diffs > ----- > > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java > e0e29652da94bbdaca515a17955d1409824c1742 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 0dd3eb101709969a77998e1488e1c97214426cd3 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 66353e769b2d633ad9dfad2bcae25e8ad90f61d1 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IHMSHandler.java > e6de00100003bc1be12b2772e2e97102ed476cf5 > > > Diff: https://reviews.apache.org/r/65985/diff/2/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Sergio Pena > >
