> On April 11, 2018, 5:26 a.m., Gopal V wrote: > > ql/src/java/org/apache/hadoop/hive/ql/cache/results/QueryResultsCache.java > > Lines 470 (patched) > > <https://reviews.apache.org/r/66533/diff/1/?file=1995232#file1995232line470> > > > > SessionState.get().getQueryCurrentTimestamp() > > > > Possibly pass it in via QueryInfo?
Good suggestion, will make the change. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66533/#review200887 ----------------------------------------------------------- On April 10, 2018, 7:19 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66533/ > ----------------------------------------------------------- > > (Updated April 10, 2018, 7:19 p.m.) > > > Review request for hive, Gopal V and Thejas Nair. > > > Bugs: HIVE-19154 > https://issues.apache.org/jira/browse/HIVE-19154 > > > Repository: hive-git > > > Description > ------- > > - Create NotificationEventPoll to periodically query for notification events, > and pass the events to any registered EventConsumers. > - Create InvalidationEventConsumer in QueryResultsCache to use the events to > invalidate any results cache entries using the updated table. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java e540d023bd > itests/src/test/resources/testconfiguration.properties 48d62a8bf9 > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java > 3cdad284ef > ql/src/java/org/apache/hadoop/hive/ql/cache/results/QueryResultsCache.java > b1a3646624 > ql/src/java/org/apache/hadoop/hive/ql/metadata/events/EventConsumer.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/metadata/events/NotificationEventPoll.java > PRE-CREATION > ql/src/test/queries/clientpositive/results_cache_invalidation2.q > PRE-CREATION > ql/src/test/results/clientpositive/llap/results_cache_invalidation2.q.out > PRE-CREATION > ql/src/test/results/clientpositive/results_cache_invalidation2.q.out > PRE-CREATION > service/src/java/org/apache/hive/service/server/HiveServer2.java 47f84b5e73 > > > Diff: https://reviews.apache.org/r/66533/diff/1/ > > > Testing > ------- > > > Thanks, > > Jason Dere > >