----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66514/ -----------------------------------------------------------
(Updated April 11, 2018, 7:58 p.m.) Review request for hive, Eugene Koifman and Sergey Shelukhin. Changes ------- Added comment to SessionState.getTxnMgr() about avoiding use of this call. Repository: hive-git Description ------- Replace usage of SessionState.getTxnMgr() from several places, by doing some refactoring to make the TxnManager available in fields passed in during construction/initialization: - SemanticAnalyzer.genFileSinkPlan() - ReplicationSemanticAnalyzer.analyzeReplLoad() - LoadSemanticAnalyzer.analyzeExternal() - ImportSemanticAnalyzer.prepareImport() - DDLSemanticAnalyzer.handleTransactionalTable() Diffs (updated) ----- llap-ext-client/src/java/org/apache/hadoop/hive/llap/LlapBaseInputFormat.java 3aec46be51 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java bda2af3a04 ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java a8d851fd81 ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/ReplLoadTask.java 6b333d7184 ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/LoadConstraint.java 60c85f58e5 ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/LoadFunction.java bc7d0ad0b9 ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadPartitions.java 06adc64727 ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadTable.java 1395027159 ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/util/Context.java bb51f36a25 ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 7a7bdea89d ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java f38b0bc546 ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 8b639f7922 ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java e49089b91e ql/src/java/org/apache/hadoop/hive/ql/parse/MaterializedViewRebuildSemanticAnalyzer.java e5af95b121 ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSemanticAnalyzer.java 79b2e48ee2 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 10982ddbd1 ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/message/MessageHandler.java 3ccd639d62 ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/message/TableHandler.java 4cd75d8128 ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 6003ced27e ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java fe570f0f8e Diff: https://reviews.apache.org/r/66514/diff/3/ Changes: https://reviews.apache.org/r/66514/diff/2-3/ Testing ------- Thanks, Jason Dere