-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66585/
-----------------------------------------------------------
(Updated April 12, 2018, 4:29 p.m.)
Review request for hive, Aihua Xu and Sahil Takiar.
Changes
-------
MetaStoreTestUtil generates its' own JDBC url, and the URL generation is
removed from the MiniHS2 code
Bugs: HIVE-19104
https://issues.apache.org/jira/browse/HIVE-19104
Repository: hive-git
Description
-------
The main goal here is to have independent warehouse dirs, and jdbc urls when
metastores are started with MetaStoreTestUtils.startMetaStoreWithRetry
This revealed several issues:
- HCatalog tests (TestPermsGrp.java, TestHCatMultiOutputFormat.java,
TestHCatPartitionPublish.java) still used the default configurations, so the
new configs should be set
- MiniHS2 warehouse directory has to be updated after the metastore is started
- Warehouse directory permissions had to be set to 777
- One of the tests in TestHiveMetaStore.java modifies the configuration object,
so it has to be copied
Diffs (updated)
-----
hcatalog/core/src/test/java/org/apache/hive/hcatalog/cli/TestPermsGrp.java
8a2151c
hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatMultiOutputFormat.java
d9de10e
hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatPartitionPublish.java
fb6a7f4
itests/util/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java 23fcbe8
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
f007261
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/MetaStoreTestUtils.java
1d12cf9
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
6f52a52
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java
e1f81bb
Diff: https://reviews.apache.org/r/66585/diff/2/
Changes: https://reviews.apache.org/r/66585/diff/1-2/
Testing
-------
Run the previously failed tests
Thanks,
Peter Vary
