-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66604/
-----------------------------------------------------------
Review request for hive, Peter Vary and Adam Szita.
Bugs: HIVE-19158
https://issues.apache.org/jira/browse/HIVE-19158
Repository: hive-git
Description
-------
The TestAddPartitions and TestAddPartitionsFromPartSpec tests revealed that NPE
is thrown in some cases. These NPEs could be prevented with a simple null check
and a MetaException with a proper error message should be thrown instead.
Diffs
-----
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
565549a
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
9a43b2c
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/partition/spec/CompositePartitionSpecProxy.java
92813b9
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/partition/spec/PartitionListComposingSpecProxy.java
6bd29d0
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/partition/spec/PartitionSpecProxy.java
ff2dea1
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/partition/spec/PartitionSpecWithSharedSDProxy.java
61e00ea
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java
f8497c7
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitionsFromPartSpec.java
fc0c60f
Diff: https://reviews.apache.org/r/66604/diff/1/
Testing
-------
Thanks,
Marta Kuczora
