----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66414/#review201287 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/common/JavaUtils.java Line 200 (original), 200 (patched) <https://reviews.apache.org/r/66414/#comment282434> the trailing "_" is probably wrong. Not all deltas have a suffix. delta_x_y is a valid name. common/src/java/org/apache/hadoop/hive/common/JavaUtils.java Line 219 (original), 218 (patched) <https://reviews.apache.org/r/66414/#comment282431> what is the purpose of this if block? seems to do nothing useful ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Line 2239 (original), 2211 (patched) <https://reviews.apache.org/r/66414/#comment282437> obsolte todo ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Line 2241 (original), 2213 (patched) <https://reviews.apache.org/r/66414/#comment282438> is this todo still meaningfu? - Eugene Koifman On April 5, 2018, 12:24 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66414/ > ----------------------------------------------------------- > > (Updated April 5, 2018, 12:24 p.m.) > > > Review request for hive and Eugene Koifman. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 75c07b41b2 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java > 0168472bdc > itests/src/test/resources/testconfiguration.properties d2e077b509 > ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 7eba5e88d8 > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 5fbe045df5 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java eed37a1937 > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java > e49089b91e > ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java b0dfc48165 > ql/src/test/results/clientpositive/mm_loaddata.q.out > > > Diff: https://reviews.apache.org/r/66414/diff/2/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
