-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66774/
-----------------------------------------------------------

(Updated April 24, 2018, 6:35 p.m.)


Review request for hive and Peter Vary.


Changes
-------

Fixed review findings.


Bugs: HIVE-19285
    https://issues.apache.org/jira/browse/HIVE-19285


Repository: hive-git


Description
-------

Subclasses of MetaDataOperation are not writing anything to the logs. It would 
be useful to have some INFO and DEBUG level logging in these classes.


Diffs (updated)
-----

  
service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java
 7944467 
  
service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java 
d67ea90 
  
service/src/java/org/apache/hive/service/cli/operation/GetCrossReferenceOperation.java
 99ccd4e 
  
service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java
 091bf50 
  
service/src/java/org/apache/hive/service/cli/operation/GetPrimaryKeysOperation.java
 e603fdd 
  
service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java 
de09ec9 
  
service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
 59cfbb2 
  
service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java 
c9233d0 
  
service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java
 ac078b4 
  service/src/java/org/apache/hive/service/cli/operation/MetadataOperation.java 
bf7c021 


Diff: https://reviews.apache.org/r/66774/diff/2/

Changes: https://reviews.apache.org/r/66774/diff/1-2/


Testing
-------

Just adding some additional log messages. Tested locally by checking the log 
messages for different use cases


Thanks,

Marta Kuczora

Reply via email to