----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66805/#review202211 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Lines 1255 (patched) <https://reviews.apache.org/r/66805/#comment283963> Instead of doing instanceof check here, you would get the same behaviour if you Override getAllOutputs() methods in LoadSemanticAnalyzer right? - Prasanth_J On May 1, 2018, 7:56 p.m., Deepak Jaiswal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66805/ > ----------------------------------------------------------- > > (Updated May 1, 2018, 7:56 p.m.) > > > Review request for hive, Ashutosh Chauhan, Eugene Koifman, Jesús Camacho > Rodríguez, Prasanth_J, and Vineet Garg. > > > Bugs: HIVE-19311 > https://issues.apache.org/jira/browse/HIVE-19311 > > > Repository: hive-git > > > Description > ------- > > Currently, "load data" statement is very limited. It errors out if any of the > information is missing such as partitioning info if table is partitioned or > appropriate names when table is bucketed. > It should be able to launch an insert job to load the data instead. > > > Diffs > ----- > > data/files/load_data_job/bucketing.txt PRE-CREATION > data/files/load_data_job/load_data_1_partition.txt PRE-CREATION > data/files/load_data_job/partitions/load_data_1_partition.txt PRE-CREATION > data/files/load_data_job/partitions/load_data_2_partitions.txt PRE-CREATION > data/files/load_data_job/partitions/subdir/load_data_1_partition.txt > PRE-CREATION > data/files/load_data_job/partitions/subdir/load_data_2_partitions.txt > PRE-CREATION > itests/src/test/resources/testconfiguration.properties 2ca7b5f63b > ql/src/java/org/apache/hadoop/hive/ql/Context.java 0fedf0e76e > ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 94dd63641d > ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java abd678bb54 > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java > c07991d434 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > fad0e5c24a > > ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java > 2f3b07f4af > ql/src/test/org/apache/hadoop/hive/ql/TestTxnLoadData.java ec8c1507ec > ql/src/test/queries/clientnegative/load_part_nospec.q 81517991b2 > ql/src/test/queries/clientnegative/nopart_load.q 966982fd5c > ql/src/test/queries/clientpositive/load_data_using_job.q PRE-CREATION > ql/src/test/results/clientnegative/load_part_nospec.q.out bebaf92311 > ql/src/test/results/clientnegative/nopart_load.q.out 881514640c > ql/src/test/results/clientpositive/llap/load_data_using_job.q.out > PRE-CREATION > > > Diff: https://reviews.apache.org/r/66805/diff/7/ > > > Testing > ------- > > Added a unit test. > > > Thanks, > > Deepak Jaiswal > >