----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67039/#review202793 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java Lines 280 (patched) <https://reviews.apache.org/r/67039/#comment284787> the reader seeks mostly delegates to data stream seek and length stream seek (RLE seeks does more than just position seek - it has to seek within bytes or runs) ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java Lines 1076 (patched) <https://reviews.apache.org/r/67039/#comment284788> Positions are packed variable in protobuf. Also there is stream suppression. Same column in a stripe may have a stream suppressed (say all non-nulls values, isPresent gets suppressed) then its positions will not be recorded. Same column in another stripe might have all streams. So all this does is if the stream does not exist don't move on to next position. [[0,0,0],[0,0],[0,0]] -> positions for isPresent, Data, Length.. [[0,0],[0,0]] -> positions for Data, Length.. (isPresent suppressed) ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java Lines 1894 (patched) <https://reviews.apache.org/r/67039/#comment284789> where is this skipSeek() implementation? I don't see it in the patch or master. - Prasanth_J On May 9, 2018, 7:12 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67039/ > ----------------------------------------------------------- > > (Updated May 9, 2018, 7:12 p.m.) > > > Review request for hive and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java > fc0c66a888 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java > 1d7eceb1ef > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java > 42532f9a0e > > > Diff: https://reviews.apache.org/r/67039/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
