----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67073/#review203208 -----------------------------------------------------------
Thanks for the patch Bharath! One question, and one suggestion is below. Peter ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java Lines 85 (patched) <https://reviews.apache.org/r/67073/#comment285302> I would prefer to thow an exception here instead of working with the default version. Better for the user to see the error faster, and not only after a long query run, when the output is not formatted as expected. What do you think? ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java Lines 143 (patched) <https://reviews.apache.org/r/67073/#comment285304> Why is this null check needed? - Peter Vary On May 15, 2018, 11:18 p.m., Bharathkrishna Guruvayoor Murali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67073/ > ----------------------------------------------------------- > > (Updated May 15, 2018, 11:18 p.m.) > > > Review request for hive, Peter Vary, Sahil Takiar, and Vihang Karajgaonkar. > > > Repository: hive-git > > > Description > ------- > > Adding support to retain the time part (HH:mm:ss) for add_months UDF when the > input is given as timestamp format. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java > dae4b97b4a17e98122431e5fda655fd9f873fdb5 > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFAddMonths.java > af9b6c43c7dafc69c4944eab02894786af306f35 > > > Diff: https://reviews.apache.org/r/67073/diff/2/ > > > Testing > ------- > > Added unit tests. > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >
