> On April 18, 2018, 9:52 p.m., Alexander Kolbasov wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Line 3323 (original), 3396 (patched) > > <https://reviews.apache.org/r/66667/diff/1/?file=2004741#file2004741line3399> > > > > Should we set interrupted flag on the thread if we get > > InterruptedException? > > Marta Kuczora wrote: > Could you please give me some details about why you think it is needed? I > don't know actually if it is needed or not. My idea here was to go through on > all FutureTasks and if one of them didn't finish successfully (there was > either an error or the task was interrupted), throw an exception, cause it > would mean that not all partition folders were created successfully. For this > I don't think that I should set anything on the thread, but I might miss > something. So could you please explain me your thoughts on this?
I just uploaded a new patch with this change. - Marta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66667/#review201465 ----------------------------------------------------------- On May 23, 2018, 4:24 p.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66667/ > ----------------------------------------------------------- > > (Updated May 23, 2018, 4:24 p.m.) > > > Review request for hive, Peter Vary, Sahil Takiar, and Adam Szita. > > > Bugs: HIVE-19046 > https://issues.apache.org/jira/browse/HIVE-19046 > > > Repository: hive-git > > > Description > ------- > > The biggest part of these methods use the same code. Refactored these code > parts to common methods. > > > Diffs > ----- > > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 92d2e3f > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java > 88064d9 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitionsFromPartSpec.java > debcd0e > > > Diff: https://reviews.apache.org/r/66667/diff/3/ > > > Testing > ------- > > > Thanks, > > Marta Kuczora > >
