----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67351/ -----------------------------------------------------------
Review request for hive, Alexander Kolbasov and Vihang Karajgaonkar. Bugs: HIVE-19718 https://issues.apache.org/jira/browse/HIVE-19718 Repository: hive-git Description ------- Various optimization for addPartitions call: - Push down table object to convertToMPart - Push down partitionKeys to startAddPartition -> doesPartitionExist -> getMPartition, so it does not have to query the table object for every time if we add multiple partitions for the same table - The original getMPartition used to query the table every time. Created a new version of getMPartition, which can use the provided partitionKeys instead of querying it again. Diffs ----- itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 3d6fda6 standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c1d25db standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 13ccdb1 standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java ce7d286 standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java b223920 standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java f6899be standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 98a85cc Diff: https://reviews.apache.org/r/67351/diff/1/ Testing ------- Run several performance tests with Sasha's performance tool. These optimisations shave of ~10% of the runtime Thanks, Peter Vary