-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67399/
-----------------------------------------------------------
(Updated June 1, 2018, 10:23 a.m.)
Review request for hive, Alexander Kolbasov and Vihang Karajgaonkar.
Changes
-------
Addressed Vihang's comments
Bugs: HIVE-19503
https://issues.apache.org/jira/browse/HIVE-19503
Repository: hive-git
Description
-------
The patch contains 2 tests:
Test which checks if the JDO cache is able to handle directSql partition drops
Test which checks if the directSQL partition drop removes every connected data
from the RDBMS tables.
To create these tests we have 2 helper methods:
Method to create the partitioned table
Method to check the number of rows in a given RDBMS table
Added a new ObjectStore.dropPartitionsInternal method which only visible for
testing so we can make sure that the dropPartition is using directSql and does
not fall back to JDO.
Fixed a problem where some of the tables are not created automatically by the
tests, adding new init queries to MetaStoreDirectSql.ensureDbInit method
Diffs (updated)
-----
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
5bb1985
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
b15d89d
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java
9912213
Diff: https://reviews.apache.org/r/67399/diff/2/
Changes: https://reviews.apache.org/r/67399/diff/1-2/
Testing
-------
Run the new tests
Thanks,
Peter Vary
