----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67468/#review204836 -----------------------------------------------------------
Why not show the #of EC files for regular explain plans too? To decrease the # of q file updates, it can be omitted if the # of EC files = 0 standalone-metastore/src/main/java/org/apache/hadoop/hive/common/StatsSetupConst.java Line 116 (original), 122 (patched) <https://reviews.apache.org/r/67468/#comment287582> why change this from an array to a list? - Sahil Takiar On June 6, 2018, 12:46 a.m., Andrew Sherman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67468/ > ----------------------------------------------------------- > > (Updated June 6, 2018, 12:46 a.m.) > > > Review request for hive and Sahil Takiar. > > > Repository: hive-git > > > Description > ------- > > HIVE-18118: provide supportability support for Erasure Coding > [NOTE THIS REVIEW INITIALLY OMITS 200+ .q.out changes] > Update number of Erasure Coded Files in a directory as part of Basic (aka > Quick) Stats > This information is then (mostly) available through 'EXPLAIN EXTENDED' and > 'DESCRIBE EXTENDED' > Extend the MiniHS2 Builder to allow configuring the number of datanodes. > Add a jdbc MiniHS2/Spark test that uses Erasure Coding. > There are some change to StatsSetupConst to make checkstyle happy. > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java > d7d7097336fc6be4c2f7a35cd6897e0375486e81 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2ErasureCoding.java > PRE-CREATION > itests/src/test/resources/testconfiguration.properties > 463fda1913f6d5b928fcee038f19e124b0239e96 > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java > 2365fb76bd08f3a310e81ac3a19ca64971aeec8e > itests/util/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java > 1700c08d3f37285de43b5d4fe5c77ef55c170235 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java > e06949928d179cfd9a4dcb7176203b885aaaa509 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > 209fdfb287cabc5bb7cab2117d771f7907deb2b9 > ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsNoJobTask.java > d4d46a3671efdaaed32f63b7262b963cce00b94e > ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java > 8c238871765b0d5312a459a0e7f68c81f3837c13 > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > 982b18076180ba300094f30a7f87f025f993b265 > ql/src/test/queries/clientpositive/erasure_explain.q PRE-CREATION > ql/src/test/queries/clientpositive/erasure_simple.q > c08409c17787417b986d90a43104f5ddd456e600 > ql/src/test/results/clientpositive/erasurecoding/erasure_explain.q.out > PRE-CREATION > ql/src/test/results/clientpositive/erasurecoding/erasure_simple.q.out > 01f6015a346c1e4283fd6a8cf1eaa3b670450e20 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/common/StatsSetupConst.java > 78ea01d9687fe043d63441430c46b30c25cd9756 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 77ed2b4de4569fa8aca23b16f2b362b187c7c4fc > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > 9b36d09eb9fb332e913d442bb476628eca334b6e > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreUtils.java > 55ff1502d415dea52095cfdd523d01f1e49ce084 > > > Diff: https://reviews.apache.org/r/67468/diff/1/ > > > Testing > ------- > > Ran driver tests and new jdbc test > > > Thanks, > > Andrew Sherman > >
