-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67895/
-----------------------------------------------------------
(Updated July 13, 2018, 9:22 a.m.)
Review request for hive.
Changes
-------
Rebased to top of master again...
Bugs: HIVE-18705
https://issues.apache.org/jira/browse/HIVE-18705
Repository: hive-git
Description
-------
HiveMetaStoreClient.dropDatabase has a strange implementation to ensure dealing
with client side hooks (for non-native tables e.g. HBase). Currently it starts
by retrieving all the tables from HMS, and then sends dropTable calls to HMS
table-by-table. At the end a dropDatabase just to be sure
I believe this could be refactored so that it speeds up the dropDB in
situations where the average table count per DB is very high.
Diffs (updated)
-----
hbase-handler/src/test/queries/positive/drop_database_table_hooks.q
PRE-CREATION
hbase-handler/src/test/results/positive/drop_database_table_hooks.q.out
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/metadata/TableIterable.java
d8e771d0ffa7d680b2a22436727f896674cd40ff
ql/src/test/org/apache/hadoop/hive/ql/metadata/TestTableIterable.java
6637d150b84c9fa86e6a3a90449606437e7c9d72
service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java
838dd89ca82792ca8af8eb0f30aa63e690e41f43
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
8d88749effa89e50d8be8ed216419cd77836fd34
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
bfd7141a8b987e5288277a46d56de32574d9aa69
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/TableIterable.java
PRE-CREATION
standalone-metastore/metastore-common/src/test/java/org/apache/hadoop/hive/metastore/TestTableIterable.java
PRE-CREATION
Diff: https://reviews.apache.org/r/67895/diff/2/
Changes: https://reviews.apache.org/r/67895/diff/1-2/
Testing
-------
Drop database is an existing feature - existing tests should be fine, but since
I'm poking around client side hooks I've added an HBase drop db qtest so that
code path is covered
Thanks,
Adam Szita
