Re: Review Request 67970: HIVE-20204 Type conversion during IN () comparisons is using different rules from other comparison operations

Thu, 19 Jul 2018 13:12:36 -0700 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67970/
-----------------------------------------------------------

(Updated July 19, 2018, 8:12 p.m.)


Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez.


Changes
-------

Update to fix failures in join45.q,join47.q,mapjoin47.q


Bugs: HIVE-20204
    https://issues.apache.org/jira/browse/HIVE-20204


Repository: hive-git


Description
-------

Change GenericUDFIn to use FunctionRegistry.getCommonClassForComparison() to 
match type conversion done during other comparison operations.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 0800a10541 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
 2ae015adf4 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFIn.java 
cf26fce00f 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java 
c91865b173 
  ql/src/test/queries/clientpositive/orc_ppd_decimal.q 2134a9f207 
  ql/src/test/queries/clientpositive/parquet_ppd_decimal.q e8e118d541 
  ql/src/test/queries/clientpositive/vectorization_parquet_ppd_decimal.q 
0b0811b055 
  ql/src/test/results/clientpositive/llap/orc_ppd_decimal.q.out 4b535d4480 
  ql/src/test/results/clientpositive/parquet_ppd_decimal.q.out c9a4338dbf 
  ql/src/test/results/clientpositive/vectorization_parquet_ppd_decimal.q.out 
49d7354b60 


Diff: https://reviews.apache.org/r/67970/diff/2/

Changes: https://reviews.apache.org/r/67970/diff/1-2/


Testing
-------


Thanks,

Jason Dere

Reply via email to