----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68124/#review206707 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java Line 846 (original), 841 (patched) <https://reviews.apache.org/r/68124/#comment289778> Can we 1) move this method to OperatorUtils, and 2) keep this method private, and 3) create a void public entry method for the recursion, where we give the _found_ set to the private one, then return the _found_ set? ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java Line 865 (original) <https://reviews.apache.org/r/68124/#comment289783> Cool! ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java Line 914 (original), 917 (patched) <https://reviews.apache.org/r/68124/#comment289780> Can be collapsed into single line in if condition. ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java Line 918 (original), 922 (patched) <https://reviews.apache.org/r/68124/#comment289782> _workRSOps_ and _workTerminalOps_ ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java Line 920 (original), 924 (patched) <https://reviews.apache.org/r/68124/#comment289779> No need to pass empty set, see comment above. ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java Line 934 (original) <https://reviews.apache.org/r/68124/#comment289781> Loop on _candidate_ here to populate _terminalOpToRSMap_. Then you can get rid of the 3-level nested loops below. - Jesús Camacho Rodríguez On July 31, 2018, 11:07 p.m., Deepak Jaiswal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68124/ > ----------------------------------------------------------- > > (Updated July 31, 2018, 11:07 p.m.) > > > Review request for hive, Jesús Camacho Rodríguez and Jason Dere. > > > Bugs: HIVE-20252 > https://issues.apache.org/jira/browse/HIVE-20252 > > > Repository: hive-git > > > Description > ------- > > See Jira. > > removeSemiJoinCyclesDueToMapsideJoins is deprecated, although it has changes. > I will eventually remove it and can be ignored. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 538aa5e924 > ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java c3eb886fd2 > > > Diff: https://reviews.apache.org/r/68124/diff/2/ > > > Testing > ------- > > > Thanks, > > Deepak Jaiswal > >
