[
https://issues.apache.org/jira/browse/HIVE-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170747#comment-13170747
]
jirapos...@reviews.apache.org commented on HIVE-2005:
-----------------------------------------------------
bq. On 2011-12-16 03:26:25, Carl Steinbach wrote:
bq. > ql/src/test/queries/clientpositive/udf_between.q, line 1
bq. > <https://reviews.apache.org/r/3008/diff/5/?file=64857#file64857line1>
bq. >
bq. > I'm not sure why you changed this testcase. The original version was
better.
bq. >
bq. > * The first two lines should be:
bq. > DESCRIBE FUNCTION between
bq. > DESCRIBE FUNCTION EXTENDED between;
bq. >
bq. > * Please call EXPLAIN on each query before running it.
bq. >
bq. > * Is there any reason in particular why you create the T1 table
instead of reusing the 'src' table that gets created automatically for all
CliDriver tests? Loading data will definitely make the test run more slowly.
Cause renaming 'btw' to 'between' made impossible to compile queries like
'SELECT between(false, 'b', 'a', 'c') FROM src LIMIT 1;'. Could you give me
some better test queries?
I'll add DESCRIBE part and EXPLAIN part, shortly.
- Navis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3008/#review3943
-----------------------------------------------------------
On 2011-12-16 02:09:08, Navis Ryu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3008/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-16 02:09:08)
bq.
bq.
bq. Review request for hive, John Sichi and Carl Steinbach.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Revised version using 'between' UDF
bq.
bq.
bq. This addresses bug HIVE-2005.
bq. https://issues.apache.org/jira/browse/HIVE-2005
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. ql/src/test/queries/clientpositive/udf_between.q PRE-CREATION
bq. ql/src/test/results/clientpositive/show_functions.q.out e63516d
bq. ql/src/test/results/clientpositive/udf_between.q.out PRE-CREATION
bq. ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java e1c47b4
bq. ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g eecd9e7
bq. ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/3008/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. added new test : udf_between.q
bq.
bq.
bq. Thanks,
bq.
bq. Navis
bq.
bq.
> Implement BETWEEN operator
> --------------------------
>
> Key: HIVE-2005
> URL: https://issues.apache.org/jira/browse/HIVE-2005
> Project: Hive
> Issue Type: New Feature
> Components: Query Processor
> Affects Versions: 0.9.0
> Reporter: Carl Steinbach
> Assignee: Navis
> Fix For: 0.9.0
>
> Attachments: HIVE-2005.1.patch.txt
>
>
> Reference:
> http://dev.mysql.com/doc/refman/5.0/en/comparison-operators.html#operator_between
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
