----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68571/#review208141 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/util/UpgradeTool.java Line 370 (original), 370 (patched) <https://reviews.apache.org/r/68571/#comment291924> Since you are touching this can you fix the comment as well? (add space before and after `//`. standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Line 1676 (original), 1676 (patched) <https://reviews.apache.org/r/68571/#comment291925> It is better to use {} interpolation in logs: `LOG.info("Deleted {} obsolete rows from WRITE_SET", delCnt)` - Alexander Kolbasov On Aug. 30, 2018, 4:37 p.m., Karthik Manamcheri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68571/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2018, 4:37 p.m.) > > > Review request for hive, Alexander Kolbasov and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > HIVE-20372: WRTIE_SET typo in TxnHandler > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/util/UpgradeTool.java c523a76659 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 2df61b41ea > > > Diff: https://reviews.apache.org/r/68571/diff/1/ > > > Testing > ------- > > > Thanks, > > Karthik Manamcheri > >
