-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68603/
-----------------------------------------------------------

(Updated Сен. 2, 2018, 9:35 п.п.)


Review request for hive, Alexander Kolbasov, Ashutosh Chauhan, and Eugene 
Koifman.


Changes
-------

Fixed failed tests. 
-- Changes
 If provided id to the method load_open_txns less than 0, method will return 
all open transactions.


Bugs: HIVE-20459
    https://issues.apache.org/jira/browse/HIVE-20459


Repository: hive-git


Description
-------

we currently have ThriftHiveMetastore.get_open_txns() which maps to 
TxnHandler.getOpenTxns(). The usual usage is 
TxnUtils.createValidReadTxnList(GetOpenTxnsResponse txns, long currentTxn) 
where the complete list transactions is obtained from Metastore and then 
anything above currentTxn is thrown away. 
Would be useful to add ThriftHiveMetastore.get_open_txns(long txnid) and 
TxnHandler.getOpenTxns(long) to not retrieve things that will be thrown away. 
Especially when there are a lot of running transactions.


Diffs (updated)
-----

  ql/src/test/org/apache/hadoop/hive/metastore/txn/TestTxnHandler.java 
be37b2a286 
  
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
 47f96f323a 
  
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php
 0973f4f3c1 
  
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote
 a595732f04 
  
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py
 3c0d0a55b1 
  
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb
 e54a7321e2 
  standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 
feb44d5159 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
 33b22a9fc3 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
 a0ff79cc5c 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MaterializationsRebuildLockCleanerTask.java
 d35c9602a6 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
 2df61b41ea 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnStore.java
 080cc5284b 
  
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java
 4093aa7a18 


Diff: https://reviews.apache.org/r/68603/diff/2/

Changes: https://reviews.apache.org/r/68603/diff/1-2/


Testing
-------


Thanks,

Igor Kryvenko

Reply via email to