----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68474/#review208793 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SmallTableCache.java Lines 94 (patched) <https://reviews.apache.org/r/68474/#comment292990> Just a remark, note from google documentation: "Because of the performance implications of using soft references, we generally recommend using the more predictable maximum cache size instead." - denys kuzmenko On Sept. 19, 2018, 11:14 p.m., Antal Sinkovits wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68474/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2018, 11:14 p.m.) > > > Review request for hive, Naveen Gangam, Sahil Takiar, Adam Szita, and Xuefu > Zhang. > > > Repository: hive-git > > > Description > ------- > > I've modified the SmallTableCache to use guava cache, with soft references. > By using a value loader, I've also eliminated the synchronization on the > intern-ed string of the path. > > > Diffs > ----- > > ql/pom.xml d73deba440702ec39fc5610df28e0fe54baef025 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HashTableLoader.java > cf27e92bafdc63096ec0fa8c3106657bab52f370 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SmallTableCache.java > 3293100af96dc60408c53065fa89143ead98f818 > ql/src/test/org/apache/hadoop/hive/ql/exec/spark/TestSmallTableCache.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/68474/diff/2/ > > > Testing > ------- > > > Thanks, > > Antal Sinkovits > >
