> On Sept. 26, 2018, 11:47 a.m., Antal Sinkovits wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 3062 (patched) > > <https://reviews.apache.org/r/68683/diff/6/?file=2091957#file2091957line3062> > > > > Why is the default value -1? All the checks seems to go against >0. > > What happens when the value is 0?
If the degree of parallelism is lower than 1, there won't be any restrictions on number of parallel compilations. "-1" means unbounded. "0" doesn't make sence, so it's just ignored (and will be unbounded). Otherwise, number of quotas will be equal to the "hive.driver.parallel.compilation.global.limit" value. > On Sept. 26, 2018, 11:47 a.m., Antal Sinkovits wrote: > > ql/src/java/org/apache/hadoop/hive/ql/lock/CompileLock.java > > Lines 12 (patched) > > <https://reviews.apache.org/r/68683/diff/6/?file=2091959#file2091959line12> > > > > I think there is a typo here, and the it should be CompileLock.class. Thanks for the catch! - denys ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/#review209017 ----------------------------------------------------------- On Sept. 26, 2018, 1:08 p.m., denys kuzmenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68683/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2018, 1:08 p.m.) > > > Review request for hive, Zoltan Haindrich, Zoltan Haindrich, Naveen Gangam, > and Peter Vary. > > > Bugs: HIVE-20535 > https://issues.apache.org/jira/browse/HIVE-20535 > > > Repository: hive-git > > > Description > ------- > > When removing the compile lock, it is quite risky to remove it entirely. > > It would be good to provide a pool size for the concurrent compilation, so > the administrator can limit the load > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8c39de3e77 > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 737debd2ad > ql/src/java/org/apache/hadoop/hive/ql/lock/CompileLock.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/lock/CompileLockFactory.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/CompileLockTest.java PRE-CREATION > > > Diff: https://reviews.apache.org/r/68683/diff/7/ > > > Testing > ------- > > Added CompileLockTest > > > File Attachments > ---------------- > > HIVE-20535.1.patch > > https://reviews.apache.org/media/uploaded/files/2018/09/13/41f5a84a-70e5-4882-99c1-1cf98c4364e4__HIVE-20535.1.patch > HIVE-20535.14.patch > > https://reviews.apache.org/media/uploaded/files/2018/09/25/335b0f4b-ea94-41d4-881a-ec8bb870a376__HIVE-20535.14.patch > HIVE-20535.14.patch > > https://reviews.apache.org/media/uploaded/files/2018/09/25/a92b6da2-eeba-46ee-9409-162653826172__HIVE-20535.14.patch > HIVE-20535.14.patch > > https://reviews.apache.org/media/uploaded/files/2018/09/25/9db4cf76-9188-48fb-bd3d-5b28e43a791b__HIVE-20535.14.patch > > > Thanks, > > denys kuzmenko > >
