> On Sept. 26, 2018, 5:51 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > > Lines 917 (patched) > > <https://reviews.apache.org/r/68827/diff/1/?file=2091788#file2091788line917> > > > > make private > > Bharathkrishna Guruvayoor Murali wrote: > I thought this could be used separately as a utility method, if the user > has just one predicate. Should I just keep the other method which accepts a > list of predicates and make this one private?
IDK, not super important > On Sept. 26, 2018, 5:51 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/common/TestMetaStoreUtils.java > > Lines 66 (patched) > > <https://reviews.apache.org/r/68827/diff/1/?file=2091790#file2091790line66> > > > > add test with the default param map from MetastoreConf > > Bharathkrishna Guruvayoor Murali wrote: > An empty exclude pattern will remove all elements from the map! But when > it is done through configuration, the default value returns an empty array, > like new String[0]. > Hence, the predicates become an empty List. What can I do if needed to > add a test for this. What I mean is a test that works from a default MetaConf object. This make the test more close to reality. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68827/#review209031 ----------------------------------------------------------- On Sept. 28, 2018, 10:17 a.m., Bharathkrishna Guruvayoor Murali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68827/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2018, 10:17 a.m.) > > > Review request for hive and Alexander Kolbasov. > > > Bugs: HIVE-20545 > https://issues.apache.org/jira/browse/HIVE-20545 > > > Repository: hive-git > > > Description > ------- > > Clients can add large-sized parameters in Table/Partition objects. So we need > to enable adding regex patterns through HiveConf to match parameters to be > filtered from table and partition objects before serialization in HMS > notifications. > > > Diffs > ----- > > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > 30ea7f81292b0db54f4eb82468191fda38f9a0d4 > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > c681a87a1c6b10a4f9494e49a42282cf90027ad7 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/messaging/json/JSONMessageFactory.java > 2668b053205f48226da442ce65fcc2d7f6e76763 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java > 30de1c4cfa1cf019186b10583a06da0bf5491634 > > > Diff: https://reviews.apache.org/r/68827/diff/2/ > > > Testing > ------- > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >
