> On Oct. 2, 2018, 11:51 p.m., Alexander Kolbasov wrote: > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java > > Lines 123 (patched) > > <https://reviews.apache.org/r/68889/diff/2/?file=2093709#file2093709line123> > > > > Style: class fields usually follow normal camelCase. > > Do we need a subdirectory for tests? > > It is better to use joining with Path or File, e.g. > > > > Path currentPath = Paths.get(System.getProperty("java.io.tmpdir")); > > Path filePath = Paths.get(currentPath.toString(), "testDbNotif");
Fixed style issue. Now using Paths.get to create the path. Just added subDirectory just in case not to delete the java.io.tmpdir when it is being used somewhere (if at all that's possible). - Bharathkrishna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68889/#review209167 ----------------------------------------------------------- On Oct. 3, 2018, 5:09 a.m., Bharathkrishna Guruvayoor Murali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68889/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2018, 5:09 a.m.) > > > Review request for hive, Alexander Kolbasov and Andrew Sherman. > > > Bugs: HIVE-20610 > https://issues.apache.org/jira/browse/HIVE-20610 > > > Repository: hive-git > > > Description > ------- > > Adding java.io.tmpdir as tmp directory instead of /tmp > > > Diffs > ----- > > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java > 82429e36a575918d92a9b22bedcd63788ec51c5f > > > Diff: https://reviews.apache.org/r/68889/diff/3/ > > > Testing > ------- > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >
