----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68969/#review209380 -----------------------------------------------------------
All looks fine within the bounds of what I understand standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java Lines 608 (patched) <https://reviews.apache.org/r/68969/#comment293769> Add a default to case statement to catch future evil standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java Lines 4100 (patched) <https://reviews.apache.org/r/68969/#comment293770> This is a total nit but you can do this sort of thing in one line with UNTESTED AND UNTRIED stuff like filters.stream().map(s -> "(" + s + ")").collect(Collectors.joining(" AND ")); standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java Line 572 (original), 572 (patched) <https://reviews.apache.org/r/68969/#comment293771> spelling -> represent standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java Lines 645 (patched) <https://reviews.apache.org/r/68969/#comment293772> These tests that set a property in client assume stuff about the order of tests? Would it be safer for each test to undo the change it made to client at the end of the test? standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java Lines 738 (patched) <https://reviews.apache.org/r/68969/#comment293774> Maybe this boilerplate, which is repeated, should be put in a method? In fact the whole methid could use a load of helper methods to make it more readable. - Andrew Sherman On Oct. 9, 2018, 7:47 p.m., Vihang Karajgaonkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68969/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2018, 7:47 p.m.) > > > Review request for hive, Alexander Kolbasov and Andrew Sherman. > > > Bugs: HIVE-20307 > https://issues.apache.org/jira/browse/HIVE-20307 > > > Repository: hive-git > > > Description > ------- > > HIVE-20307 : Add support for filterspec to the getPartitions with projection > API > > > Diffs > ----- > > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java > d59d5d807a26378a430e683533e53d0831cf9514 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > a2b57fb646899c54b63be14a8cde9b8644a973aa > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > 16f4a50d69f9120d565f61d028b060d7776689fc > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 08614749b7aba54f9eb9b54ac46f79dbac6bc5cd > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > af757932a191675bc8fb9236209a2efba9f3d335 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 66977d79c946f1ac57aacfbe8704d37bfbac3ea3 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java > a6d9583364be20758444ebe25c8cf636f0ea740f > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > 70490f09e765d4e42391c67eb5cf018e93ad04aa > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 4dd4edccd66f8ea8ea189a2d27f970c8113e3a0f > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 06f4cbce58c16f98257e7f529ffe31c983f2919f > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java > dcff606937157e63694657b42392875d50b17be6 > > > Diff: https://reviews.apache.org/r/68969/diff/1/ > > > Testing > ------- > > > Thanks, > > Vihang Karajgaonkar > >
