-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68946/
-----------------------------------------------------------
(Updated Oct. 12, 2018, 1:35 a.m.)
Review request for hive, Ashutosh Chauhan and Jason Dere.
Changes
-------
There is more scope added to this patch
1) Support managed and external tables. Managed tables will get X lock for MSCK
REPAIR.
2) Retention period for partitions can be specified via table property.
3) MSCK repair can now handle retention periods via config.
4) All external tables will now automatically enable partition discovery.
On top of these there are fixes related to ACID, MSCK was acquiring wrong lock,
explain locks was not working for msck, fixes related to catalog handling (some
metastore APIs was not handling catalog names correctly).
Bugs: HIVE-20707
https://issues.apache.org/jira/browse/HIVE-20707
Repository: hive-git
Description
-------
HIVE-20707: Automatic MSCK REPAIR for external tables
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java cc6239c
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java
cffa21a
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java e913462
ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 46bf088
ql/src/java/org/apache/hadoop/hive/ql/metadata/CheckResult.java 0b4240f
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java
598bb2e
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 29f6ecf
ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 27f677e
ql/src/test/org/apache/hadoop/hive/ql/exec/TestMsckCreatePartitionsInBatches.java
ce2b186
ql/src/test/org/apache/hadoop/hive/ql/exec/TestMsckDropPartitionsInBatches.java
7e768da
ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveMetaStoreChecker.java
a2a0583
ql/src/test/queries/clientpositive/msck_repair_0.q aeb4820
ql/src/test/queries/clientpositive/msck_repair_2.q be745b2
ql/src/test/queries/clientpositive/msck_repair_3.q 140a690
ql/src/test/queries/clientpositive/msck_repair_acid.q PRE-CREATION
ql/src/test/queries/clientpositive/msck_repair_batchsize.q 5a7afcc
ql/src/test/queries/clientpositive/msck_repair_drop.q 9923fb5
ql/src/test/queries/clientpositive/partition_discovery.q PRE-CREATION
ql/src/test/results/clientpositive/msck_repair_0.q.out fa6e4a9
ql/src/test/results/clientpositive/msck_repair_2.q.out 7fbd934
ql/src/test/results/clientpositive/msck_repair_3.q.out 0e153fb
ql/src/test/results/clientpositive/msck_repair_acid.q.out PRE-CREATION
ql/src/test/results/clientpositive/msck_repair_batchsize.q.out ab4b831
ql/src/test/results/clientpositive/msck_repair_drop.q.out 971c138
ql/src/test/results/clientpositive/partition_discovery.q.out PRE-CREATION
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/CheckResult.java
PRE-CREATION
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java
294dfb7
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/api/MetastoreException.java
PRE-CREATION
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
7b01678
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
16f4a50
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreChecker.java
PRE-CREATION
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/Msck.java
PRE-CREATION
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MsckInfo.java
PRE-CREATION
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MsckPartitionExpressionProxy.java
PRE-CREATION
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
66977d7
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionIterable.java
PRE-CREATION
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionManagementTask.java
PRE-CREATION
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java
f3b3866
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/RetryUtilities.java
PRE-CREATION
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestPartitionManagement.java
PRE-CREATION
Diff: https://reviews.apache.org/r/68946/diff/2/
Changes: https://reviews.apache.org/r/68946/diff/1-2/
Testing
-------
Thanks,
Prasanth_J
