----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69143/#review210011 -----------------------------------------------------------
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java Lines 94 (patched) <https://reviews.apache.org/r/69143/#comment294650> Can you add a comment what's the difference between isCachePrewarmed? standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java Lines 227 (patched) <https://reviews.apache.org/r/69143/#comment294647> Log full stack standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java Lines 491 (patched) <https://reviews.apache.org/r/69143/#comment294646> Can you log the full stack trace (maybe using org.apache.hadoop.util.StringUtils.stringifyException)? There's another instance below. standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java Lines 522 (patched) <https://reviews.apache.org/r/69143/#comment294648> Make maxTries a constant (and reuse it below). standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java Lines 544 (patched) <https://reviews.apache.org/r/69143/#comment294649> maxTries should be constant. - Daniel Dai On Oct. 24, 2018, 5:04 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69143/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2018, 5:04 p.m.) > > > Review request for hive, Daniel Dai and Thejas Nair. > > > Bugs: HIVE-20613 > https://issues.apache.org/jira/browse/HIVE-20613 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-20613 > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CacheUtils.java > 944c81313a > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > 70490f09e7 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/SharedCache.java > c24e7160ac > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java > bb20d9f42a > standalone-metastore/metastore-server/src/test/resources/log4j2.properties > 365687e1c9 > > > Diff: https://reviews.apache.org/r/69143/diff/1/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
