> On Oct. 25, 2018, 4:44 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java > > Lines 1176 (patched) > > <https://reviews.apache.org/r/69167/diff/1/?file=2102460#file2102460line1176> > > > > Nit: all the trendy kids use StringBuilder now
Removed StringBuffer - Laszlo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69167/#review210043 ----------------------------------------------------------- On Oct. 25, 2018, 1:36 p.m., Laszlo Pinter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69167/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2018, 1:36 p.m.) > > > Review request for hive and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > HIVE-20796: jdbc URL can contain sensitive information that should not be > logged > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 9c158040497cd3d2762620ce35e2b46bb6d5fffe > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java > f3b38665676391fec9b85eb9a405c14632340dc6 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java > f4bdd734dc4e731dda01e6031a4115cde5571baf > > > Diff: https://reviews.apache.org/r/69167/diff/1/ > > > Testing > ------- > > New unit test created. > > > Thanks, > > Laszlo Pinter > >