-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69019/
-----------------------------------------------------------
(Updated Nov. 2, 2018, 10:10 p.m.)
Review request for hive, Ashutosh Chauhan, Jesús Camacho Rodríguez, and Vineet
Garg.
Changes
-------
patch#18
* be more safe; and not open INs when comparision of list/array would have
happen
* address review comments
* actualize q.out-s
Bugs: HIVE-20617
https://issues.apache.org/jira/browse/HIVE-20617
Repository: hive-git
Description
-------
For IN expressions the types were never corrected; and pointlookupoptimizer was
probably leaving behind fields already which were uncomparable; HIVE-20296
exposed it further by changing the minimal number from 32 to 2.
This change generalizes the retyping of constants to also run it for the IN
operator ; and also for struct-s.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/type/HiveChar.java 29dc06dca1a
ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java e7d71595c7a
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HivePointLookupOptimizerRule.java
04800cca91b
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java
c9df668d4a7
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 82e975a50de
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckCtx.java 1b56ecd0440
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
4968d16876c
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactoryUtils.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java c274fd7cc9b
ql/src/test/queries/clientnegative/udf_in_2.q 2288054d583
ql/src/test/queries/clientpositive/groupby_multi_single_reducer3.q
94aea35c422
ql/src/test/queries/clientpositive/in_typecheck_char.q PRE-CREATION
ql/src/test/queries/clientpositive/in_typecheck_mixed.q PRE-CREATION
ql/src/test/queries/clientpositive/in_typecheck_pointlook.q PRE-CREATION
ql/src/test/queries/clientpositive/in_typecheck_varchar.q PRE-CREATION
ql/src/test/queries/clientpositive/pcs.q 2e7eff472b5
ql/src/test/queries/clientpositive/vector_struct_in.q 49a9374bd13
ql/src/test/results/clientnegative/udf_in_2.q.out 83883e3f9e3
ql/src/test/results/clientpositive/alter_partition_coltype.q.out f6c3c5642ea
ql/src/test/results/clientpositive/groupby_multi_single_reducer3.q.out
a8b595a6590
ql/src/test/results/clientpositive/in_typecheck_char.q.out PRE-CREATION
ql/src/test/results/clientpositive/in_typecheck_mixed.q.out PRE-CREATION
ql/src/test/results/clientpositive/in_typecheck_pointlook.q.out PRE-CREATION
ql/src/test/results/clientpositive/in_typecheck_varchar.q.out PRE-CREATION
ql/src/test/results/clientpositive/infer_const_type.q.out e1d7de54225
ql/src/test/results/clientpositive/join45.q.out 47aaf7d0abc
ql/src/test/results/clientpositive/join45X.q.out PRE-CREATION
ql/src/test/results/clientpositive/join47.q.out 4d9e937815e
ql/src/test/results/clientpositive/llap/acid_no_buckets.q.out 5bd3d90249b
ql/src/test/results/clientpositive/llap/bucketpruning1.q.out 9422eb49781
ql/src/test/results/clientpositive/llap/check_constraint.q.out 9b1f8def6eb
ql/src/test/results/clientpositive/llap/dec_str.q.out 554031e952e
ql/src/test/results/clientpositive/llap/dynpart_sort_optimization_acid.q.out
40dc5e97e5a
ql/src/test/results/clientpositive/llap/explainuser_1.q.out f240468558e
ql/src/test/results/clientpositive/llap/is_distinct_from.q.out f5a34750ce3
ql/src/test/results/clientpositive/llap/kryo.q.out 8121c119cc7
ql/src/test/results/clientpositive/llap/lineage3.q.out 9bec309c9c9
ql/src/test/results/clientpositive/llap/multi_column_in.q.out 414be226e6a
ql/src/test/results/clientpositive/llap/multi_column_in_single.q.out
db9c676a814
ql/src/test/results/clientpositive/llap/orc_llap_counters.q.out 3b163794b60
ql/src/test/results/clientpositive/llap/orc_predicate_pushdown.q.out
21180a3da8c
ql/src/test/results/clientpositive/llap/parquet_predicate_pushdown.q.out
8330e93115c
ql/src/test/results/clientpositive/llap/vector_between_in.q.out e9ea4611acc
ql/src/test/results/clientpositive/llap/vector_struct_in.q.out 4dfa80e9843
ql/src/test/results/clientpositive/llap/vectorization_13.q.out 4ce654f960b
ql/src/test/results/clientpositive/llap/vectorization_6.q.out a2f730beca2
ql/src/test/results/clientpositive/llap/vectorization_8.q.out 21ce7b8ebd0
ql/src/test/results/clientpositive/llap/vectorization_short_regress.q.out
7f1c6a295e1
ql/src/test/results/clientpositive/mapjoin47.q.out 294dd69de5c
ql/src/test/results/clientpositive/parquet_vectorization_13.q.out 0efce98b555
ql/src/test/results/clientpositive/parquet_vectorization_6.q.out 0bb68883640
ql/src/test/results/clientpositive/parquet_vectorization_8.q.out 957bd7b264c
ql/src/test/results/clientpositive/pcs.q.out 4a89fb0787e
ql/src/test/results/clientpositive/perf/tez/cbo_query15.q.out 02ad7c207c0
ql/src/test/results/clientpositive/perf/tez/constraints/cbo_query15.q.out
b260731c8f9
ql/src/test/results/clientpositive/ppd_udf_col.q.out 814fb5afcfd
ql/src/test/results/clientpositive/spark/groupby_multi_single_reducer3.q.out
e796443d962
ql/src/test/results/clientpositive/spark/parquet_vectorization_13.q.out
38122393439
ql/src/test/results/clientpositive/spark/parquet_vectorization_6.q.out
6108457aad3
ql/src/test/results/clientpositive/spark/parquet_vectorization_8.q.out
3352dedc584
ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out
f5a4c9ad861
ql/src/test/results/clientpositive/spark/vector_between_in.q.out da2fbe741fa
ql/src/test/results/clientpositive/spark/vectorization_13.q.out 34ec9c42dd3
ql/src/test/results/clientpositive/spark/vectorization_6.q.out 5679bb8cfa4
ql/src/test/results/clientpositive/spark/vectorization_short_regress.q.out
231dea6de3e
ql/src/test/results/clientpositive/vector_non_constant_in_expr.q.out
e8e5c062783
ql/src/test/results/clientpositive/vector_struct_in.q.out 546ef02fa42
ql/src/test/results/clientpositive/vectorization_13.q.out 8897f8427ff
ql/src/test/results/clientpositive/vectorization_6.q.out 8dedb63e7da
ql/src/test/results/clientpositive/vectorization_8.q.out d81df76a2f6
Diff: https://reviews.apache.org/r/69019/diff/5/
Changes: https://reviews.apache.org/r/69019/diff/4-5/
Testing
-------
Thanks,
Zoltan Haindrich
