----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69254/#review210334 -----------------------------------------------------------
Just one question. Thanks, Peter ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java Lines 3321 (patched) <https://reviews.apache.org/r/69254/#comment294992> Is the problem only affects CBO, or RBO as well? What happens when CBO is off? ql/src/test/org/apache/hadoop/hive/ql/plan/TestViewEntity.java Lines 198 (patched) <https://reviews.apache.org/r/69254/#comment294993> Please remove extra spaces.. - Peter Vary On nov. 5, 2018, 3:14 du, Karen Coppage wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69254/ > ----------------------------------------------------------- > > (Updated nov. 5, 2018, 3:14 du) > > > Review request for hive. > > > Bugs: HIVE-20818 > https://issues.apache.org/jira/browse/HIVE-20818 > > > Repository: hive-git > > > Description > ------- > > If Hive is configured with an authorization hook like Sentry, and a view is > created with a WHERE clause referencing a different view' user has no access > to, user cannot access the view as view' is considered direct input. > WHERE IN and WHERE EXISTS cause the same issue. > Cascading views created with no WHERE clauses (i.e. with simple SELECTs and > FROM clauses) work fine. > > See Jira for example > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java ab63ce2bc3 > ql/src/test/org/apache/hadoop/hive/ql/plan/TestViewEntity.java 6ad38b8467 > > > Diff: https://reviews.apache.org/r/69254/diff/1/ > > > Testing > ------- > > Added unit test > > > Thanks, > > Karen Coppage > >
