----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69558/ -----------------------------------------------------------
Review request for hive and Ashutosh Chauhan. Bugs: HIVE-21032 https://issues.apache.org/jira/browse/HIVE-21032 Repository: hive-git Description ------- HiveMetaTool is doing everything in one class, needs to be refactored to have a nicer design. Diffs ----- bin/ext/metatool.sh 20e1c01 itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaTool.java 5bd83ac itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/tools/metatool/TestHiveMetaTool.java PRE-CREATION itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/tools/metatool/package-info.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/TestTxnExIm.java 06e3ef2 standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/HiveMetaTool.java a50c0a3 standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/metatool/HiveMetaTool.java PRE-CREATION standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/metatool/HiveMetaToolCommandLine.java PRE-CREATION standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/metatool/MetaToolTask.java PRE-CREATION standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/metatool/MetaToolTaskExecuteJDOQLQuery.java PRE-CREATION standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/metatool/MetaToolTaskListFSRoot.java PRE-CREATION standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/metatool/MetaToolTaskUpdateLocation.java PRE-CREATION standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/metatool/package-info.java PRE-CREATION standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/tools/metatool/TestHiveMetaToolCommandLine.java PRE-CREATION standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/tools/metatool/TestMetaToolTaskExecuteJDOQLQuery.java PRE-CREATION standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/tools/metatool/TestMetaToolTaskListFSRoot.java PRE-CREATION standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/tools/metatool/TestMetaToolTaskUpdateLocation.java PRE-CREATION standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/tools/metatool/package-info.java PRE-CREATION Diff: https://reviews.apache.org/r/69558/diff/1/ Testing ------- Tested on local cluster, it behaves like it used to. Wrote a lot of new unit tests. Thanks, Miklos Gergely