> On Dec. 19, 2018, 11:33 p.m., Morio Ramdenbourg wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > > Lines 816 (patched) > > <https://reviews.apache.org/r/69585/diff/2/?file=2114850#file2114850line816> > > > > Nit: This might benefit from some extra spacing or spreading them out > > into if statements. I had a difficult time reading the nested ternary > > operators (or maybe that's just me?)
I wrap it in a function. So it will be easier to read. > On Dec. 19, 2018, 11:33 p.m., Morio Ramdenbourg wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > > Lines 2458 (patched) > > <https://reviews.apache.org/r/69585/diff/2/?file=2114850#file2114850line2458> > > > > This is the same method as the one on the HiveMetaStore. Would it be > > possible to move it to a common method under > > hive-standalone-metastore-common? > > Na Li wrote: > some variables used are different. such as isClientFilterEnabled vs > isServerFilterEnabled and filterHook. If we make is generate function, those > need to be input. No sure how valuable to make that change. > > Morio Ramdenbourg wrote: > Ah, didn't notice those. If that's the case, I'm not sure either how > valuable the generic method would be. Could probably drop this recommendation I decide to have a common method under hive-standalone-metastore-common - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/#review211446 ----------------------------------------------------------- On Dec. 21, 2018, 9:36 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69585/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2018, 9:36 p.m.) > > > Review request for hive, Adam Holley, Morio Ramdenbourg, Peter Vary, Sergio > Pena, and Vihang Karajgaonkar. > > > Bugs: HIVE-20776 > https://issues.apache.org/jira/browse/HIVE-20776 > > > Repository: hive-git > > > Description > ------- > > add filtering to read result at HMS server, so user cannot see metadata > he/she has no privileges. Filtering is enabled/disabled based on > configuration. > > > Diffs > ----- > > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 9eb1193a27120b5167f92daf67bf6a1c4e1d9927 > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > fb0b2fe6fb9fd4b4c92a6a39f06f39a4641aaabd > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FilterUtils.java > PRE-CREATION > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 0a1b96dcf62d3536cab2ce074d27a6225b2d3443 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetastoreFilterHook.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/69585/diff/4/ > > > Testing > ------- > > Existing unit tests passed. > add new unit tests for filtering at HMS server and HMS client > add code to enabled/disable filtering at HMS client based on configuration > > > Thanks, > > Na Li > >
