> On Jan. 10, 2019, 11:20 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java > > Lines 254 (patched) > > <https://reviews.apache.org/r/69585/diff/8/?file=2119072#file2119072line254> > > > > Its not clear why this should throw NoSuchObjectException? Can you > > please add a comment. Are we changing the behavior of this API?
We are not changing the behavior of this API. The original behavior could throw NoSuchObjectException as well. In this specific test, NoSuchObjectException was not thrown when user cannot access a table without my patch because we did not configure pre event listener (which checks if the user can access the partition's table, and throw NoSuchObjectException when user cannot access partition's table). NoSuchObjectException is thrown now because we add checking the filter hook, and NoSuchObjectException is thrown when user cannot access a table > On Jan. 10, 2019, 11:20 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetastoreFilterHook.java > > Lines 49 (patched) > > <https://reviews.apache.org/r/69585/diff/8/?file=2119073#file2119073line49> > > > > This test looks very familiar to TestFilterHooks. What is the > > difference? If it is different, can you please add some javadoc on the top > > to explain what the test is doing. If there is not much difference can we > > refactor (or add these tests to TestFilterHooks) to re-use the code instead > > of duplicating it? I remove TestFilterHooks since its test cases are subset of what are in TestHiveMetastoreFilterHook - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/#review211843 ----------------------------------------------------------- On Jan. 10, 2019, 9:10 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69585/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2019, 9:10 p.m.) > > > Review request for hive, Adam Holley, Karthick Sankarachary, Morio > Ramdenbourg, Peter Vary, Sergio Pena, and Vihang Karajgaonkar. > > > Bugs: HIVE-20776 > https://issues.apache.org/jira/browse/HIVE-20776 > > > Repository: hive-git > > > Description > ------- > > add filtering to read result at HMS server, so user cannot see metadata > he/she has no privileges. Filtering is enabled/disabled based on > configuration. > > > Diffs > ----- > > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 748b56b0a268c1ec7dea022722478ec50889c016 > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > be1f8c78497fe3d0816ad3935ba07cd5ad379b08 > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FilterUtils.java > PRE-CREATION > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > a9398ae1e79404a15894aa42f451df5d18ed3e4c > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java > 7dc69bc4e92875c8962dcd313b16f0f90ea8b057 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetastoreFilterHook.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/69585/diff/8/ > > > Testing > ------- > > Existing unit tests passed. > add new unit tests for filtering at HMS server and HMS client > add code to enabled/disable filtering at HMS client based on configuration > add code to enabled/disable filtering at HMS server based on configuration > > > Thanks, > > Na Li > >
