-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69808/
-----------------------------------------------------------
(Updated Jan. 23, 2019, 1:10 p.m.)
Review request for hive and Ashutosh Chauhan.
Changes
-------
Fix ImmutableSet import + followup recent changes
Bugs: HIVE-21149
https://issues.apache.org/jira/browse/HIVE-21149
Repository: hive-git
Description
-------
LlapServiceDriver is one monolith class doing several things, needs to be
refactor in order to make it clearer how it works.
Diffs (updated)
-----
bin/ext/llap.sh 91a54b3
llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapOptionsProcessor.java
2445075
llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java
4bc2431
llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapSliderUtils.java
bdec1c1
llap-server/src/java/org/apache/hadoop/hive/llap/cli/service/AsyncTaskCopyAuxJars.java
PRE-CREATION
llap-server/src/java/org/apache/hadoop/hive/llap/cli/service/AsyncTaskCopyConfigs.java
PRE-CREATION
llap-server/src/java/org/apache/hadoop/hive/llap/cli/service/AsyncTaskCopyLocalJars.java
PRE-CREATION
llap-server/src/java/org/apache/hadoop/hive/llap/cli/service/AsyncTaskCreateUdfFile.java
PRE-CREATION
llap-server/src/java/org/apache/hadoop/hive/llap/cli/service/AsyncTaskDownloadTezJars.java
PRE-CREATION
llap-server/src/java/org/apache/hadoop/hive/llap/cli/service/LlapConfigJsonCreator.java
PRE-CREATION
llap-server/src/java/org/apache/hadoop/hive/llap/cli/service/LlapServiceCommandLine.java
PRE-CREATION
llap-server/src/java/org/apache/hadoop/hive/llap/cli/service/LlapServiceDriver.java
PRE-CREATION
llap-server/src/java/org/apache/hadoop/hive/llap/cli/service/LlapTarComponentGatherer.java
PRE-CREATION
llap-server/src/java/org/apache/hadoop/hive/llap/cli/service/package-info.java
PRE-CREATION
llap-server/src/test/org/apache/hadoop/hive/llap/cli/service/TestLlapServiceCommandLine.java
PRE-CREATION
llap-server/src/test/org/apache/hadoop/hive/llap/cli/service/package-info.java
PRE-CREATION
Diff: https://reviews.apache.org/r/69808/diff/2/
Changes: https://reviews.apache.org/r/69808/diff/1-2/
Testing
-------
Tested on actual cluster, llap still starts up fine.
Thanks,
Miklos Gergely
