> On Jan. 24, 2019, 4:08 p.m., Adam Holley wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/FilterUtils.java > > Lines 1 (patched) > > <https://reviews.apache.org/r/69831/diff/1/?file=2122035#file2122035line1> > > > > Since this is a new class, can the style be consistent? e.g. Blank line > > or not at the beginning of a method, line wrap for method parameters and > > return calls.
I'm not sure if it's a big deal, but the line wrap for the method declaration is not consistent. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69831/#review212276 ----------------------------------------------------------- On Jan. 24, 2019, 5:19 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69831/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2019, 5:19 p.m.) > > > Review request for hive and Vihang Karajgaonkar. > > > Bugs: hive-20776 > https://issues.apache.org/jira/browse/hive-20776 > > > Repository: hive-git > > > Description > ------- > > add filtering to read result at HMS server, so user cannot see metadata > he/she has no privileges. Filtering is enabled/disabled based on > configuration. > > > Diffs > ----- > > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 40affeff1714eab68800fb2acd191ae5c90097de > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 57377779e89bb3bfbb477b0ba7a48094f5ac78ad > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > 46a6d532b63a6f1b3a3bc1ac4d272eee775f0ff3 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/FilterUtils.java > PRE-CREATION > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java > 7dc69bc4e92875c8962dcd313b16f0f90ea8b057 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java > a8b6e316da33e6fd4b484534eb8e915d5128a89e > > > Diff: https://reviews.apache.org/r/69831/diff/2/ > > > Testing > ------- > > Existing unit tests passed. > add new unit tests for filtering at HMS server and HMS client > add code to enabled/disable filtering at HMS client based on configuration > add code to enabled/disable filtering at HMS server based on configuration > > > Thanks, > > Na Li > >
