cricket007 commented on a change in pull request #526: HIVE-21218: KafkaSerDe 
doesn't support topics created via Confluent
URL: https://github.com/apache/hive/pull/526#discussion_r254990871
 
 

 ##########
 File path: kafka-handler/src/resources/SimpleRecord.avsc
 ##########
 @@ -0,0 +1,13 @@
+{
+  "type" : "record",
+  "name" : "SimpleRecord",
+  "namespace" : "org.apache.hadoop.hive.kafka",
+  "fields" : [ {
 
 Review comment:
   It's not really relevant for this PR, but as part of the DDL, we have 
`col_comment`
   
   ```
   CREATE [TEMPORARY] [EXTERNAL] TABLE [IF NOT EXISTS] [db_name.]table_name    
-- (Note: TEMPORARY available in Hive 0.14.0 and later)
     [(col_name data_type [COMMENT col_comment], ... 
[constraint_specification])]
    ```
   
   And if you look at the Avro spec, you'll see `doc` can be a field added, 
much like JavaDoc comments for classes and fields 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to