kgyrtkirk commented on a change in pull request #548: HIVE-21313: Use faster
method to prevent copying bytes twice
URL: https://github.com/apache/hive/pull/548#discussion_r259755027
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorAssignRow.java
##########
@@ -452,11 +452,11 @@ private void assignRowColumn(
{
if (object instanceof byte[]) {
byte[] bytes = (byte[]) object;
- ((BytesColumnVector) columnVector).setVal(
+ ((BytesColumnVector) columnVector).setRef(
batchIndex, bytes, 0, bytes.length);
} else {
BytesWritable bw = (BytesWritable) object;
- ((BytesColumnVector) columnVector).setVal(
+ ((BytesColumnVector) columnVector).setRef(
Review comment:
I think writeables are usually reused; don't they?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
