[ https://issues.apache.org/jira/browse/HIVE-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2674: ------------------------------ Attachment: HIVE-2674.D987.1.patch kevinwilfong requested code review of "HIVE-2674 [jira] get_partitions_ps throws TApplicationException if table doesn't exist". Reviewers: JIRA getPartitionPsQueryResults now throws a NoSuchObjectException instead of a NPE if the table named does not exist. I updated all calls higher up so that the exception could propagate to Thrift client. If the table passed to get_partition_ps doesn't exist, a NPE is thrown by getPartitionPsQueryResults. There should be a check here, which throws a NoSuchObjectException if the table doesn't exist. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D987 AFFECTED FILES metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php metastore/if/hive_metastore.thrift MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/2055/ Tip: use the X-Herald-Rules header to filter Herald messages in your client. > get_partitions_ps throws TApplicationException if table doesn't exist > --------------------------------------------------------------------- > > Key: HIVE-2674 > URL: https://issues.apache.org/jira/browse/HIVE-2674 > Project: Hive > Issue Type: Bug > Components: Metastore > Reporter: Kevin Wilfong > Assignee: Kevin Wilfong > Attachments: HIVE-2674.D987.1.patch > > > If the table passed to get_partition_ps doesn't exist, a NPE is thrown by > getPartitionPsQueryResults. There should be a check here, which throws a > NoSuchObjectException if the table doesn't exist. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira