kgyrtkirk commented on a change in pull request #544: HIVE-16924 Support
distinct in presence of Group By
URL: https://github.com/apache/hive/pull/544#discussion_r259878502
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
##########
@@ -4230,6 +4229,34 @@ public static long unsetBit(long bitmap, int bitIdx) {
}
}
+ protected boolean isGroupBy(ASTNode expr) {
+ boolean isGroupBy = false;
+ if (expr.getParent() != null && expr.getParent() instanceof Node)
+ for (Node sibling : ((Node)expr.getParent()).getChildren()) {
+ isGroupBy |= sibling instanceof ASTNode && ((ASTNode)sibling).getType()
== HiveParser.TOK_GROUPBY;
+ }
+
+ return isGroupBy;
+ }
+
+ protected boolean isSelectDistinct(ASTNode expr) {
+ return expr.getType() == HiveParser.TOK_SELECTDI;
+ }
+
+ protected boolean isAggregateInSelect(Node node, Collection<ASTNode>
aggregateFunction) {
+ if (node.getChildren() == null) {
+ return false;
+ }
+
+ for (Node child : node.getChildren()) {
Review comment:
I was thinking something really odd:
```
select distinct (select count(*) from t where t.a=e.a) from e
```
but in this case (beyond that it might not accept by hive at all) the count
aggregate is not present at the top level.
Do you know an example when this method returns false; however there are
aggreagations being done?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
