dlavati commented on a change in pull request #550: HIVE-21198 Introduce a
database object reference class
URL: https://github.com/apache/hive/pull/550#discussion_r260830699
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/incremental/IncrementalLoadTasksBuilder.java
##########
@@ -266,16 +271,15 @@ private boolean shouldReplayEvent(FileStatus dir,
DumpType dumpType, String dbNa
return updateReplIdTxnTask;
}
- private Task<? extends Serializable> tableUpdateReplStateTask(String dbName,
String tableName,
- Map<String, String>
partSpec, String replState,
- Task<? extends
Serializable> preCursor) throws SemanticException {
+ private Task<? extends Serializable> tableUpdateReplStateTask(TableName
tableName, Map<String, String> partSpec,
Review comment:
Besides a greater level of enforcement, is there any other benefit?
Inside `org.apache.hadoop.hive.ql.plan` only `ShowLocksDesc` is using both
tableName, dbName and partitionspec, the other Desc classes that have
partitionspec only use tableName.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
