vineetgarg02 commented on a change in pull request #552: Hive 21279
URL: https://github.com/apache/hive/pull/552#discussion_r260915364
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
##########
@@ -1463,6 +1474,19 @@ private static String replaceTaskIdFromFilename(String
filename, String oldTaskI
return snew.toString();
}
+
+ public static boolean shouldAvoidRename(FileSinkDesc conf, Configuration
hConf) {
+ // we are avoiding rename/move only if following conditions are met
+ // * execution engine is tez
+ // * query cache is disabled
+ // * if it is select query
+ if (conf != null && conf.getIsQuery() && conf.getFilesToFetch() != null
Review comment:
@ashutoshc conf could be null. There is FileMerge operator which calls this
code passing conf as NULL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
